Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[FxA] Settings page show incorrect signin page with a new firefox account #5193

Closed
punamdahiya opened this issue Nov 17, 2018 · 1 comment
Closed

[FxA] Settings page show incorrect signin page with a new firefox account #5193

punamdahiya opened this issue Nov 17, 2018 · 1 comment
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
Sprint 27 (66-1)

Comments

@punamdahiya
Copy link
Contributor

Settings page shows incorrect signin page when logged in with Firefox Account that doesn't have a deviceId associated to it.

In confirm-login, we are saving profile data in account only when deviceId exists causing empty accountInfo on settings page

firefox-not-signed-in
@punamdahiya punamdahiya mentioned this issue Nov 19, 2018
Closed
@johngruen johngruen added this to the Sprint 27 (66-1) milestone Nov 20, 2018
@ianb ianb closed this as completed in a800b25 Nov 20, 2018
ianb added a commit that referenced this issue Nov 20, 2018
@ianb
Merge pull request #5206 from punamdahiya/5193-settings-page-fxa
f63503d 
Fixes #5193 - Settings page shows incorrect signin page after login w…
@SoftVision-CosminMuntean
Copy link

I have verified this issue using the latest Screenshots dev and stage server (36.3.0) and is no longer reproducible.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 27, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
Sprint 27 (66-1)
Development

No branches or pull requests
3 participants
@punamdahiya @johngruen @SoftVision-CosminMuntean