This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Merge v10 #3191
Merged
Merge v10 #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds : (important on Windows), \, <, and > to the blacklist. Followup in #3083
In test conditions, when the browser is started and stopped very quickly, sometimes we didn't shut down the WebExtension because it hadn't fully started. r=kmag (in https://bugzilla.mozilla.org/show_bug.cgi?id=1373614)
* Validate iframe URLs Remove unneeded iframe onload handlers * Put temporary clipboard TEXTAREA in an iframe With iframe URL validation
* set dimensions for icon and add to startup (#3136) * Address 10.6 review comments (bug 1381132) * Update version to 10.7.0 with changelog
* Do not re-wrap onResize when adding and removing the listener This caused the removeEventListener to silently fail, as the wrapped functions did not match (by identity) Fixes #3153 * Suppress error popups for all errors in resize handlers Errors still go to Sentry
…ots into v10.4.0-export
jaredhirsch
approved these changes
Jul 24, 2017
| @@ -275,14 +277,16 @@ this.ui = (function() { // eslint-disable-line no-unused-vars | |||
| }, | |||
|
|
|||
| hide() { | |||
| window.removeEventListener("scroll", this.onScroll); | |||
| window.removeEventListener("scroll", watchFunction(assertIsTrusted(this.onScroll))); | |||
There was a problem hiding this comment.
I didn't catch this before, but just as with this.onResize, if we wrap this.onScroll inline, removeEventListener will fail to detach the listener. It doesn't lead to any thrown errors, but is a memory leak. I'm fine to address this here or in a followup bug.
There was a problem hiding this comment.
I'll make a followup: #3198
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3142
The ui.js merge was a little hairy, extra attention to that file would be welcome.