Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Track undo/redo events #4761

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

chenba
Copy link
Collaborator

@chenba chenba commented Aug 10, 2018

Fixes #4735

@codecov-io
Copy link

codecov-io commented Aug 10, 2018

Codecov Report

Merging #4761 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4761      +/-   ##
==========================================
- Coverage    41.7%   41.66%   -0.05%     
==========================================
  Files          43       43              
  Lines        1899     1901       +2     
  Branches      353      353              
==========================================
  Hits          792      792              
- Misses       1107     1109       +2
Impacted Files Coverage Δ
server/src/pages/shot/editor.js 7.17% <0%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88810c...6280cdc. Read the comment docs.

Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenba chenba force-pushed the 4735-undo-redo-events branch from c0084a2 to 6280cdc Compare August 13, 2018 14:46
@chenba chenba dismissed jaredhirsch’s stale review August 13, 2018 14:48

Added the events to the metrics doc. (Also added the ones for the text tool.) Thanks!

Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching the text tool docs as well

@jaredhirsch jaredhirsch merged commit 1257f22 into mozilla-services:master Aug 13, 2018
chenba added a commit to chenba/screenshots that referenced this pull request Aug 31, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants