Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Windows Python bindings #2003

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Windows Python bindings #2003

merged 1 commit into from
Apr 8, 2019

Conversation

lissyx
Copy link
Collaborator

@lissyx lissyx commented Apr 3, 2019

Fixes #1937

@lissyx lissyx self-assigned this Apr 3, 2019
@lissyx lissyx force-pushed the py-win branch 28 times, most recently from 2b65886 to c4046af Compare April 5, 2019 07:24
@lissyx lissyx force-pushed the py-win branch 13 times, most recently from 7598a99 to cfe029e Compare April 7, 2019 19:04
@lissyx lissyx changed the title Setup pyenv-win Windows Python bindings Apr 8, 2019
@lissyx lissyx force-pushed the py-win branch 4 times, most recently from 88023c4 to 44aaf42 Compare April 8, 2019 10:37
@lissyx lissyx requested a review from reuben April 8, 2019 10:40
@lissyx lissyx force-pushed the py-win branch 2 times, most recently from a676828 to 453ad1a Compare April 8, 2019 11:27
# for the dynamic linker
if platform.system().lower() == "windows":
dslib_path = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'lib')
os.environ['PATH'] = dslib_path + ';' + os.environ['PATH']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows dynamic linker uses PATH to find libraries?! That's so weird.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is :/

tc-tests-utils.sh Outdated Show resolved Hide resolved
@lissyx lissyx merged commit 594cf5a into mozilla:master Apr 8, 2019
@lock
Copy link

lock bot commented May 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 8, 2019
@lissyx lissyx deleted the py-win branch January 13, 2020 19:02
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Python bindings
2 participants