Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not run tests twice after editing a file #5793

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Do not run tests twice after editing a file #5793

merged 1 commit into from
Jul 31, 2018

Conversation

willdurand
Copy link
Member

@willdurand willdurand commented Jul 31, 2018

Fix mozilla/addons#10514


I find this behavior annoying and found the GH issue last night, so here is a patch.
I hooked into the Jest process to see which files were triggering a re-run.

@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #5793 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    mozilla/addons-frontend#5793   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files         228      228           
  Lines        5683     5683           
  Branches     1096     1096           
=======================================
  Hits         5551     5551           
  Misses        116      116           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea324c...fd8cb6b. Read the comment docs.

Copy link
Contributor

@muffinresearch muffinresearch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ Nice fix.

@willdurand willdurand merged commit a51bf03 into master Jul 31, 2018
@willdurand willdurand deleted the jest branch July 31, 2018 14:37
@kumar303
Copy link
Contributor

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest --watch runs tests twice after editing a file
4 participants