Move SyncTelemetryPing
to a-c, to fix class resolution errors
#1269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
SyncTelemetryPing
from a-s doesn't work well with Fenix. 😭 a-c and Fenix build just fine (and the a-c unit tests pass!), but syncing in Fenix throws anjava.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Failed resolution of: Lmozilla/appservices/sync15/SyncTelemetryPing
runtime exception.Changing Fenix to depend on a-s, and adding
sync15
as anapi
instead of animplementation
dependency doesn't work. This takes the hacky (but maybe better, in the long term?) approach of movingSyncTelemetryPing
into a-c (mozilla-mobile/android-components#3092), which does work in Fenix.Pull Request checklist
cargo test --all
produces no test failurescargo clippy --all --all-targets --all-features
runs without emitting any warningscargo fmt
does not produce any changes to the code./gradlew ktlint detekt
runs without emitting any warningsswiftformat --swiftversion 4 megazords components/*/ios && swiftlint
runs without emitting any warnings or producing changes[ci full]
to the PR title.