Skip to content

Move SyncTelemetryPing to a-c, to fix class resolution errors #1269

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

linabutler
Copy link
Contributor

Importing SyncTelemetryPing from a-s doesn't work well with Fenix. 😭 a-c and Fenix build just fine (and the a-c unit tests pass!), but syncing in Fenix throws an java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Failed resolution of: Lmozilla/appservices/sync15/SyncTelemetryPing runtime exception.

Changing Fenix to depend on a-s, and adding sync15 as an api instead of an implementation dependency doesn't work. This takes the hacky (but maybe better, in the long term?) approach of moving SyncTelemetryPing into a-c (mozilla-mobile/android-components#3092), which does work in Fenix.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • cargo test --all produces no test failures
    • cargo clippy --all --all-targets --all-features runs without emitting any warnings
    • cargo fmt does not produce any changes to the code
    • ./gradlew ktlint detekt runs without emitting any warnings
    • swiftformat --swiftversion 4 megazords components/*/ios && swiftlint runs without emitting any warnings or producing changes
    • Note: For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@linabutler linabutler requested a review from thomcc June 10, 2019 21:12
@linabutler
Copy link
Contributor Author

Fixed by mozilla-mobile/fenix#3325.

@linabutler linabutler closed this Jun 10, 2019
@rfk rfk deleted the move-pings-to-ac branch June 7, 2021 10:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant