Update rust version to 1.68 #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5439 +/- ##
==========================================
- Coverage 45.11% 45.10% -0.01%
==========================================
Files 172 172
Lines 14378 14376 -2
==========================================
- Hits 6487 6485 -2
Misses 7891 7891
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mhammond
force-pushed
the
update-rust-168
branch
from
d2ccbe7 to
c80335d
Compare
bendk
approved these changes
Mar 23, 2023
| # Probably https://github.com/rust-lang/rust/issues/97549 which is a 1.61 issue. | ||
| # We should revert this once we move past 1.61 | ||
| - run: RUST_LOG=trace cargo test -j2 | ||
| - run: RUST_LOG=trace cargo test |
| @@ -30,6 +30,7 @@ pub enum SyncedBookmarkValue<T> { | |||
| Specified(T), | |||
| } | |||
|
|
|||
| #[allow(clippy::derivable_impls)] // 1.65 gets upset if we derive default here due to the <T> | |||
There was a problem hiding this comment.
Maybe note that we should switch to Derive once the min-version is 1.68.
mhammond
force-pushed
the
update-rust-168
branch
from
c80335d to
412aa9d
Compare
mhammond
force-pushed
the
update-rust-168
branch
from
412aa9d to
e02201b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now m-c is on 1.68 I thought I'd see that the fallout is. Fixes #5435, but blocked by #5436.
Most changes mage by clippy.