Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Handling mixing with discrete channel hardware #16

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Handling mixing with discrete channel hardware #16

merged 5 commits into from
Apr 22, 2024

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented Apr 16, 2024

No description provided.

padenot added 2 commits April 16, 2024 14:53
@padenot
Add a new channel position: Discrete, that can appear in duplicate an…
5fd6398 
…d doesn't map to a particular channel position.

This channel is to be used based on its index, and is useful for
professional sound cards.
@padenot
Detect and properly handle discrete channels
f152f8a
@padenot padenot requested a review from Pehrsons April 16, 2024 12:56
Pehrsons
Pehrsons requested changes Apr 17, 2024
View reviewed changes
Copy link

@Pehrsons Pehrsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one logic issue. I also wouldn't mind if you fixed the nightly warning to unbust those jobs, it's a trivial legacy constant on coefficient.rs:457.

src/coefficient.rs Outdated Show resolved Hide resolved
@padenot padenot force-pushed the discrete-channels-fix branch from 8985c56 to 9ce0bd6 Compare April 17, 2024 13:59
Pehrsons
Pehrsons approved these changes Apr 18, 2024
View reviewed changes
Copy link

@Pehrsons Pehrsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, but I have a question on the test.
Approving though, so you can solve it at your own discretion.

src/coefficient.rs Show resolved Hide resolved
src/coefficient.rs Outdated Show resolved Hide resolved
@padenot padenot force-pushed the discrete-channels-fix branch from 9ce0bd6 to 9bb2deb Compare April 22, 2024 13:10
@padenot padenot force-pushed the discrete-channels-fix branch from 9bb2deb to d6e21b4 Compare April 22, 2024 13:12
@padenot padenot merged commit 29b5b45 into master Apr 22, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Pehrsons Pehrsons Pehrsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padenot @Pehrsons