Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix content-script overriding body css for every page #860

Closed
wants to merge 1 commit into from

Conversation

rittme
Copy link

@rittme rittme commented Sep 8, 2022

Fix the issue from #857.

The current content_script.css is overriding the body tag css properties for every page.

@rocramer
Copy link

rocramer commented Sep 8, 2022

Should be merged ASAP.

@Vinnl
Copy link

Vinnl commented Sep 8, 2022

Just a heads-up that a non-broken update should now be available, so updating the extension should fix the issue from #857 for now: #857 (comment)

@privacytoolsIO
Copy link

Same issue, was very concerning since the text was changed to black on a dark gray background on our website https://www.privacytools.io/

@groovecoder
Copy link
Member

Thanks @rittme for the contribution, and thanks everyone for the quick feedback on this. We will be more diligent about testing website compatibility in the future.

90K users received the buggy 2.3.3 version, and now 109K users are on the latest 2.3.4 (i.e., the rollback) version. 1.1M users are still on 2.3.2, but their next update should jump them straight to 2.3.4 instead of the buggy 2.3.3.

We are working on a full fix to include the security improvements, performance improvements, AND the bug-fix for the styling issue.

We merged #868 to fix the styling issue, if anyone here would like to help us spot-check that fix with the same sites that people saw this PR fix. Closing this PR for now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants