Remove the test_set_channel_layout_input #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling audiounit_get_current_channel_layout by input-only (microphone-only) AudioUnit is prone to cause crash intermittently. The test_set_channel_layout_input is likely to cause intermittent crash since it calls audiounit_get_current_channel_layout by a input-only AudioUnit. Removing this test can avoid the random crashes when running `cargo test` (#31). The cubeb implementation has no need to get the channel-layout on input side, so the test_set_channel_layout_input is unnecessary anyway.
padenot
approved these changes
Dec 19, 2019
Sure, I'll keep the #31 open |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling audiounit_get_current_channel_layout by input-only
(microphone-only)
AudioUnitis prone to cause crash intermittently.The
test_set_channel_layout_inputis likely to cause intermittent crashsince it calls
audiounit_get_current_channel_layoutby an input-onlyAudioUnit. Removing this test can avoid the random crashes when runningcargo test(#31).The cubeb implementation has no need to get the channel-layout on input
side, so the
test_set_channel_layout_inputis unnecessary anyway.