fix(totp): replace recovery codes keyboard accessibility #7090
Conversation
|
For reference, with keyboard accessibility working: |
|
@vbudhram - could you review this? |
There was a problem hiding this comment.
@karansapolia Thanks for the PR, I think a better solution in this scenario is to use a button instead of a link. You will need to style the button to look like a link though. By doing this you can remove the href tag.
Oh alright, let me do that and update the PR. |
|
@vbudhram have made the requested changes. review please. |
There was a problem hiding this comment.
@karansapolia This is almost there! Just a couple minor things.
Make 'Replace recovery codes' keyboard accessible. Replace earlier used link with button element to allow tab indexing and keyboard click events for keyboard accessibility. fixes: #6593
|
@vbudhram review please. |
|
This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo. |
Make 'Replace recovery codes' link keyboard accessible.
Add ability for tab indexing through link and pressing enter
to click on link.
fixes: #6593
@ryanfeeley Would request you to review.