bug(admin-server): Broken logs #18336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - Some analytics were lost - A refactor broke logging This commit: - Restores mzlog.service.ts to its previous glory - Fixes wonky injection - Fixes circular ref in admin-panel gaurds that would sometimes cause esbuild error - Fixes project.json in libs/shared/sentry to avoid esbuild error
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-10920
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Working Example from Train-294
28|admin-server | 2025-02-06T15:30:38: {"Timestamp":1738884638766000000,"Logger":"fxa-user-admin-server","Type":"default.admin-panel-events","Severity":6,"Pid":70121,"EnvVersion":"2.0","Fields":{"event":"account-search","search-type":"email","auto-completed":false}}Broken Example from train-305. Note "Fields": { "0": "{...}"}. This won't ingest into our logging tables properly.
28|admin-server | 2025-02-06T15:06:20: {"Timestamp":1738883180094000000,"Logger":"fxa-user-admin-server","Type":"EventLoggingService.","Severity":6,"Pid":40424,"EnvVersion":"2.0","Fields":{"0":"{\"event\":\"account-search\",\"search-type\":\"email\",\"auto-completed\":false}","message":"admin-panel-events"}}With fix in this PR:
28|admin-server | 2025-02-06T16:13:29: {"Timestamp":1738887209919000000,"Logger":"fxa-user-admin-server","Type":"EventLoggingService.admin-panel-events","Severity":6,"Pid":37694,"EnvVersion":"2.0","Fields":{"event":"account-search","search-type":"email","auto-completed":true}}Other information (Optional)
The build error fixes cropped up of all a sudden. Maybe these should be a separate PR? Pulled my hair out trying to figure out why this was happening... I also added a few follows based on this PR to the logging cleanup epic. Basically our logger use is getting more and more inconsistent. We need a full pass to clean this up to remove the partial refactors and ensuing code duplication. This was started in the FXA-10970 branch, ended up bailing on the attempt, because the size of the commit was getting out of hand, hence the FXA-10970.2 branch name.