Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

task(ci): Make runs consistent #18354

Merged
merged 1 commit into from
Feb 12, 2025
Merged

task(ci): Make runs consistent #18354

merged 1 commit into from
Feb 12, 2025

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Feb 11, 2025 •
edited
Loading

Because

  • We track metrics on number of tests, failures, skips, etc... for nighty and build / deploy.
  • Using nx affected resulted in different numbers of tests being run, which skewed metrics.

This pull request

  • Runs all test suites, not just affected suites, for test_and_deploy, and nightly
  • Improves parallelization.
  • Removes extra build in unit-test job.

Issue that this pull request solves

Closes: FXA-11115

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Note, not sure why unit test job had a build a step. It was probably a necessary hack at some point. Let's see if we can remove this. 🤞

@dschom dschom requested a review from a team as a code owner February 11, 2025 19:50
@dschom
task(ci): Make runs consistent
7275436 
Because:
- We track metrics on number of tests, failures, skips, etc...
- Using `nx affected` resulted in different numbers of tests being run, which skewed metrics.

This Commit:
- Runs all test suites, not just affected, suites for test_and_deploy, and nightly
- Improves parallelization.
- Removes extra build in unit-test job.

Note, not sure why unit test job had a build a step. It was probably a necessary hack at some point. Let's see if we can remove this.
@dschom dschom merged commit 7116d0e into main Feb 12, 2025
23 checks passed
@dschom dschom deleted the FXA-11115 branch February 12, 2025 17:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vbudhram vbudhram vbudhram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschom @vbudhram