Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(metrics): remove Navigation Timing lvl2 metrics from Settings #18489

Merged
merged 1 commit into from
Feb 28, 2025
Merged

chore(metrics): remove Navigation Timing lvl2 metrics from Settings #18489

merged 1 commit into from
Feb 28, 2025

Conversation

chenba
Copy link
Contributor

@chenba chenba commented Feb 28, 2025

Because:

  • the data did not appear to be reliable
  • we use other tools for frontend performance monitoring now
  • the backend route was deleted at some point, causing 404s

This commit:

  • delete the route handler on the server and the frontend call on Settings

@chenba
chore(metrics): remove Navigation Timing lvl2 metrics from Settings
59a4bba 
Because:
 - the data did not appear to be reliable
 - we use other tools for frontend performance monitoring now
 - the backend route was deleted at some point, causing 404s

This commit:
 - delete the route handler on the server and the frontend call on
   Settings
@chenba chenba requested a review from a team as a code owner February 28, 2025 14:43
vbudhram
vbudhram approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@chenba chenba merged commit add3ef8 into main Feb 28, 2025
24 checks passed
@chenba chenba deleted the no-nav-timing branch February 28, 2025 15:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vbudhram vbudhram vbudhram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenba @vbudhram