fix(tests): wait for Redis to stop #18507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
force-pushed
the
try-waiting-for-redis-to-stop
branch
from
1cf05f9 to
c4fa107
Compare
chenba
force-pushed
the
try-waiting-for-redis-to-stop
branch
from
c4fa107 to
cf466f5
Compare
chenba
commented
Mar 4, 2025
| console.log('mail_helper started...'); | ||
| printMatchingKeys(true); | ||
| return resolve({ | ||
| close() { | ||
| return new Promise((resolve, reject) => { | ||
| let smtpClosed = false; | ||
| let apiClosed = false; | ||
| redis.quit(); |
There was a problem hiding this comment.
We were seeing errors because we did not wait for this before resolving the promise.
chenba
commented
Mar 4, 2025
| let stops = 0; | ||
| const cb = () => { | ||
| stops += 1; | ||
| if (stops >= numStops) { |
There was a problem hiding this comment.
I don't really want to spend the CI credit to update this to ++stops >= numStops; sorry about the extra line.
vpomerleau
approved these changes
Mar 4, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.