WIP #18522
Closed
WIP #18522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
force-pushed
the
remove-recovery-phone-config-from-gql
branch
from
333f134 to
4f5ef84
Compare
We use separate env files because I suspect we will want to change more things in these configurations over time for each environment. The `CIRRUS_ENV_NAME` is a configuration that ended up already being deployed with the appropriate values. Fixes FXA-11218
Because: - We ended up using recovery phone service just in auth server This Commit - Removes recovery phone service references - Removes orphaned downstream dependencies - Fixes nx tag so integration tests run in ci again - Fixes two broken integration tests
dschom
force-pushed
the
remove-recovery-phone-config-from-gql
branch
from
4f5ef84 to
c2755d6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.