Reject files if they use unit by mistake
#432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
catch-missing-time-unit
branch
2 times, most recently
from
88a5f3e to
d02cfc9
Compare
chutten
reviewed
Jan 7, 2022
badboy
force-pushed
the
catch-missing-time-unit
branch
3 times, most recently
from
e456bbf to
e4bdb46
Compare
badboy
force-pushed
the
catch-missing-time-unit
branch
from
e4bdb46 to
f4271c1
Compare
chutten
approved these changes
Jan 10, 2022
The time metric types use `time_unit`, not `unit`. Easy mistake to made, we can catch that. Note: `time_unit` is OPTIONAL for all three metric types. This is not a problem for `memory_distribution`, because its `memory_unit` is REQUIRED.
badboy
force-pushed
the
catch-missing-time-unit
branch
from
25f9d27 to
fc0e682
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time metric types use
time_unit, notunit.Easy mistake to made, we can catch that.
Note:
time_unitis OPTIONAL for all three metric types.This is not a problem for
memory_distribution, because itsmemory_unitis REQUIRED.Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one