Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Correctly serialize Rates as documented into CommonMetricData #530

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Correctly serialize Rates as documented into CommonMetricData #530

merged 1 commit into from
Dec 1, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Dec 1, 2022

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@badboy badboy requested a review from travis79 December 1, 2022 15:39
travis79
travis79 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@badboy badboy enabled auto-merge (rebase) December 1, 2022 16:04
@badboy badboy merged commit 4e2b161 into main Dec 1, 2022
@badboy badboy deleted the handle-rates-for-rust-codegen branch December 2, 2022 14:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@travis79 travis79 travis79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badboy @travis79