Don't `Label` prefix the inner type of a labeled metric #533

badboy · 2022-12-07T15:08:24Z

Quality: This PR builds and tests run cleanly
- make test runs without emitting any warnings
- make lint runs without emitting any errors
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
- Any breaking changes to language binding APIs are noted explicitly

This allows us to generate non-generic code to turn strings into the correct type.

badboy requested a review from travis79 December 7, 2022 15:08

badboy mentioned this pull request Dec 7, 2022

Rust: Wrap labels in Cow #534

Merged

3 tasks

travis79 approved these changes Dec 7, 2022

View reviewed changes

badboy added 2 commits December 8, 2022 10:19

Don't Label prefix the inner type of a labeled metric

5774bee

Rust: Wrap labels in Cow

3da4003

This allows us to generate non-generic code to turn strings into the correct type.

badboy force-pushed the rust-fix-label-inner branch from 76a9206 to 3da4003 Compare December 8, 2022 09:19

badboy enabled auto-merge (rebase) December 8, 2022 09:19

badboy merged commit 8c78966 into main Dec 8, 2022

badboy deleted the rust-fix-label-inner branch December 12, 2023 09:43

Provide feedback