Bug 1913129 - Remove Geckoview Streaming helper code #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
remove-gvst-helper
branch
from
b0fb095 to
e882fee
Compare
|
It is breaking, because ESR 128 is also using glean_parser 14. Revert the removal of the alias. Release that as a patch release. |
This is not in use anymore. Last use removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1877836 We don't remove support for _parsing_ `gecko_datapoint` to stay compatible with already existing old definition files.
badboy
force-pushed
the
remove-gvst-helper
branch
from
e882fee to
ade3a88
Compare
badboy
changed the title
travis79
approved these changes
Aug 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not in use anymore.
Last use removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1877836
We don't remove support for parsing
gecko_datapointto stay compatible with already existing old definition files.Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one