Fix #501: add maybe_update_issue_milestone step

[leplatrem]

Fix #501

[leplatrem]

@cpeterso would that logic work for you as an MVP?

[cpeterso]

Does this update work with field name fixVersions? I think fixVersions (plural) should be fixVersion (singular). The field is displayed as "Fix versions" in the Jira issue UI, but it is called fixVersion (singular) in JQL queries.

[leplatrem]

Weird. fixVersions is a system field (does not seem custom), and I don't see why it would be singular in JQL.

These are the fields with version in their name on our Jira instance:

[
   {
      "id":"customfield_10747",
      "key":"customfield_10747",
      "name":"App Version",
      "untranslatedName":"App Version",
      "custom":true,
      "orderable":true,
      "navigable":true,
      "searchable":true,
      "clauseNames":[
         "App Version",
         "App Version[Paragraph]",
         "cf[10747]"
      ],
      "schema":{
         "type":"string",
         "custom":"com.atlassian.jira.plugin.system.customfieldtypes:textarea",
         "customId":10747
      }
   },
   {
      "id":"customfield_10463",
      "key":"customfield_10463",
      "name":"Version",
      "untranslatedName":"Version",
      "custom":true,
      "orderable":true,
      "navigable":true,
      "searchable":true,
      "clauseNames":[
         "cf[10463]",
         "Version",
         "Version[Short text]"
      ],
      "schema":{
         "type":"string",
         "custom":"com.atlassian.jira.plugin.system.customfieldtypes:textfield",
         "customId":10463
      }
   },
   {
      "id":"customfield_10315",
      "key":"customfield_10315",
      "name":"Changed Fix Versions",
      "untranslatedName":"Changed Fix Versions",
      "custom":true,
      "orderable":true,
      "navigable":true,
      "searchable":true,
      "clauseNames":[
         "cf[10315]",
         "Changed Fix Versions",
         "Changed Fix Versions[Paragraph]"
      ],
      "schema":{
         "type":"string",
         "custom":"com.atlassian.jira.plugin.system.customfieldtypes:textarea",
         "customId":10315
      }
   },
   {
      "id":"customfield_10184",
      "key":"customfield_10184",
      "name":"Targeted version and channel",
      "untranslatedName":"Targeted version and channel",
      "custom":true,
      "orderable":true,
      "navigable":true,
      "searchable":true,
      "clauseNames":[
         "cf[10184]",
         "Targeted version and channel",
         "Targeted version and channel[Dropdown]"
      ],
      "schema":{
         "type":"option",
         "custom":"com.atlassian.jira.plugin.system.customfieldtypes:select",
         "customId":10184
      }
   },
   {
      "id":"customfield_10185",
      "key":"customfield_10185",
      "name":"Rollout will become default in version:",
      "untranslatedName":"Rollout will become default in version:",
      "custom":true,
      "orderable":true,
      "navigable":true,
      "searchable":true,
      "clauseNames":[
         "cf[10185]",
         "Rollout will become default in version:",
         "Rollout will become default in version:[Dropdown]"
      ],
      "schema":{
         "type":"option",
         "custom":"com.atlassian.jira.plugin.system.customfieldtypes:select",
         "customId":10185
      }
   },
   {
      "id":"fixVersions",
      "key":"fixVersions",
      "name":"Fix versions",
      "custom":false,
      "orderable":true,
      "navigable":true,
      "searchable":true,
      "clauseNames":[
         "fixVersion"
      ],
      "schema":{
         "type":"array",
         "items":"version",
         "system":"fixVersions"
      }
   },
   {
      "id":"versions",
      "key":"versions",
      "name":"Affects versions",
      "custom":false,
      "orderable":true,
      "navigable":true,
      "searchable":true,
      "clauseNames":[
         "affectedVersion"
      ],
      "schema":{
         "type":"array",
         "items":"version",
         "system":"versions"
      }
   }
]

[cpeterso]

Weird. fixVersions is a system field (does not seem custom), and I don't see why it would be singular in JQL.

I haven't used Jira's API, but when I search with JQL fixVersions = Fx124, Jira returns an error:

Field 'fixVersions' does not exist or you do not have permission to view it.

https://mozilla-hub.atlassian.net/issues/?jql=fixVersions%20%3D%20Fx124

When I search with fixVersion = Fx124, Jira returns a list of 162 issues:

https://mozilla-hub.atlassian.net/issues/?jql=fixVersion%20%3D%20Fx124

[cpeterso]

@cpeterso would that logic work for you as an MVP?

I can't say anything about this Python code, but the PR's logic to map Bugzilla's NNN Branch to Jira's FxNNN or Release NNN looks OK to me. I added some questions in the PR.

[cpeterso]

Where will the "Bug %s milestone %r has no matching version in project." errors be logged when a Bugzilla Milestone name doesn't match the Jira Release? Is that information only available to JBI admins?

[leplatrem]

These are application/server logs that end-up in Google Cloud console. We currently don't have any way to send alerts to users (we could consider adding a comment on the bug or on the Jira issue)