fix: Simplify neqo_common::log and enforce clippy format checks
#2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
+ Coverage 93.33% 95.31% +1.98%
==========================================
Files 114 114
Lines 36899 36844 -55
Branches 36899 36844 -55
==========================================
+ Hits 34440 35119 +679
- Misses 1682 1717 +35
+ Partials 777 8 -769 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 648863b. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Nit: Remove trailing dots to make messages more consistent.
larseggert
changed the title
neqo_common::log with log crate
larseggert
changed the title
neqo_common::log with log crateneqo_common::log and enforce clippy format checks
Signed-off-by: Lars Eggert <lars@eggert.org>
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.154 µs 11.191 µs 11.233 µs]
change: [-0.2669% +0.0566% +0.4206%] (p = 0.74 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0157 ms 3.0242 ms 3.0343 ms]
change: [-0.6219% -0.1451% +0.3373%] (p = 0.55 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.563 µs 19.643 µs 19.750 µs]
change: [-0.7127% +0.0233% +0.6606%] (p = 0.95 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1591 ms 5.1705 ms 5.1835 ms]
change: [-0.4603% -0.1092% +0.2477%] (p = 0.54 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5319 µs 5.5497 µs 5.5751 µs]
change: [-0.8053% +0.0390% +0.9298%] (p = 0.93 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7622 ms 1.7693 ms 1.7787 ms]
change: [-0.3241% +0.2275% +0.7815%] (p = 0.46 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.030 ns 99.351 ns 99.679 ns]
change: [-0.0994% +0.2960% +0.7023%] (p = 0.16 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.99 ns 117.38 ns 117.78 ns]
change: [-0.6739% +0.1787% +0.8422%] (p = 0.69 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.47 ns 116.98 ns 117.58 ns]
change: [-0.2539% +0.7440% +1.9239%] (p = 0.23 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.209 ns 101.96 ns 112.55 ns]
change: [-1.2602% +1.9954% +7.1418%] (p = 0.55 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.99 ms 112.04 ms 112.09 ms]
change: [+0.6478% +0.8483% +0.9784%] (p = 0.00 < 0.05)
SentPackets::take_ranges: Change within noise threshold. time: [5.5200 µs 5.6941 µs 5.8815 µs]
change: [+0.1899% +2.7566% +5.2939%] (p = 0.04 < 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [41.783 ms 41.864 ms 41.950 ms]
change: [+0.0554% +0.3413% +0.6400%] (p = 0.02 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.061 ms 42.146 ms 42.236 ms]
change: [+0.0417% +0.3023% +0.5641%] (p = 0.03 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [41.887 ms 41.960 ms 42.036 ms]
change: [+0.0720% +0.3403% +0.5984%] (p = 0.01 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [41.972 ms 42.042 ms 42.116 ms]
change: [-0.3954% -0.1432% +0.0976%] (p = 0.26 > 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [886.52 ms 897.01 ms 907.78 ms]
thrpt: [110.16 MiB/s 111.48 MiB/s 112.80 MiB/s]
change:
time: [-0.3979% +1.1399% +2.8221%] (p = 0.17 > 0.05)
thrpt: [-2.7446% -1.1271% +0.3995%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: 💔 Performance has regressed. time: [317.18 ms 319.55 ms 322.01 ms]
thrpt: [31.055 Kelem/s 31.294 Kelem/s 31.528 Kelem/s]
change:
time: [+4.6062% +5.6804% +6.7336%] (p = 0.00 < 0.05)
thrpt: [-6.3088% -5.3751% -4.4034%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.263 ms 34.498 ms 34.755 ms]
thrpt: [28.773 elem/s 28.987 elem/s 29.186 elem/s]
change:
time: [-0.3736% +0.5612% +1.4828%] (p = 0.24 > 0.05)
thrpt: [-1.4611% -0.5581% +0.3750%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.6682 s 1.6859 s 1.7039 s]
thrpt: [58.690 MiB/s 59.316 MiB/s 59.943 MiB/s]
change:
time: [+0.0887% +1.6030% +3.2145%] (p = 0.05 < 0.05)
thrpt: [-3.1144% -1.5777% -0.0886%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <lars@eggert.org>
mxinden
approved these changes
Jan 10, 2025
Signed-off-by: Lars Eggert <lars@eggert.org>
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Jan 17, 2025
mozilla#2291 added additional formatting to our log output via `env_logger`'s `auto-color` feature. The `auto-color` feature adds the `is-terminal` crate dependency. `is-terminal` depends on `hermit-abi` `v0.4`. Pulling latest Neqo `v0.12.0` into mozilla-central adds `is-terminal` and `hermit-abi` `v0.4.0` to the Firefox dependency tree. In order to keep our dependency footprint low, I suggest not enabling the two `env-logger` features.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
) * deps(common/log): drop env_logger's auto-color and regex features #2291 added additional formatting to our log output via `env_logger`'s `auto-color` feature. The `auto-color` feature adds the `is-terminal` crate dependency. `is-terminal` depends on `hermit-abi` `v0.4`. Pulling latest Neqo `v0.12.0` into mozilla-central adds `is-terminal` and `hermit-abi` `v0.4.0` to the Firefox dependency tree. In order to keep our dependency footprint low, I suggest not enabling the two `env-logger` features. * chore: bump version to v0.12.1
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move variables into format strings where possible and make some other minor improvements.
Offshoot off #1963.