Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unload the pdfstreamconverter on shutdown. #1193

Merged
merged 1 commit into from
Feb 8, 2012

Conversation

brendandahl
Copy link
Contributor

Hopefully one of the last review concerns.
"Your add-on now loads the PDFStreamConverter via Cu,import. Hence it should Cu.unload that module again during shutdown not only to avoid memory leaks, but also to avoid the previous version to be still loaded and used after updates."

@notmasteryet
Copy link
Contributor

@pdfjsbot lint

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2012

Processing command lint by user notmasteryet. Queue size: 0

Live script output is available (after queueing is done) at: http://184.73.87.52:8989/3878540.txt

[bot:processed:3878540]

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2012

All tests passed.

Output:

========== Killing any stray processes

========== Running garbage collector in /home/ubuntu/pdf.js-bot/tmp
Collecting garbage...

========== Cloning pull request repo
Cloning into ....

========== Merging upstream into pull request clone

========== Running 'make lint'
gjslint --nojsdoc  src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js  web/compatibility.js web/viewer.js test/driver.js examples/helloworld/hello.js extensions/firefox/bootstrap.js extensions/firefox/components/PdfStreamConverter.js  test/unit/crypto_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js
31 files checked, no errors found.

All done.


_____________________________ stderr:

Bot response time: 0.93 mins

notmasteryet added a commit that referenced this pull request Feb 8, 2012
Unload the pdfstreamconverter on shutdown.
@notmasteryet notmasteryet merged commit 7859ef0 into mozilla:master Feb 8, 2012
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants