-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Keep logical assignment operators in MOZCENTRAL
/TESTING
-builds
#12887
Keep logical assignment operators in MOZCENTRAL
/TESTING
-builds
#12887
Conversation
Given how recently logical assignment operators support were added to browsers, we're intentionally translating them even in `SKIP_BABEL = true` builds for the time being. However, in either `MOZCENTRAL` or `TESTING` builds it should be OK to simply leave logical assignment operators intact.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ce53ad03a946c3b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/c444304881dc462/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ce53ad03a946c3b/output.txt Total script time: 3.69 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/c444304881dc462/output.txt Total script time: 4.68 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6404cfcf87aba5f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/f1ebfce84792e72/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6404cfcf87aba5f/output.txt Total script time: 2.98 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/f1ebfce84792e72/output.txt Total script time: 3.92 mins
|
Looks like a good idea! |
Given how recently logical assignment operators support were added to browsers, we're intentionally translating them even in
SKIP_BABEL = true
builds for the time being.However, in either
MOZCENTRAL
orTESTING
builds it should be OK to simply leave logical assignment operators intact.