Update some deprecated ESLint rules #13890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see https://eslint.org/docs/rules/#deprecated where the following rules apply to the PDF.js project: - [`no-buffer-constructor`](https://eslint.org/docs/rules/no-buffer-constructor), which we can replace with the `unicorn/no-new-buffer` rule; see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-new-buffer.md - [`no-catch-shadow`](https://eslint.org/docs/rules/no-catch-shadow), which was replaced by the `no-shadow` rule (that we're already using).
|
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/694d14e14c5c46f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/24c86bfebe19998/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/24c86bfebe19998/output.txt Total script time: 2.49 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/694d14e14c5c46f/output.txt Total script time: 4.44 mins
|
timvandermeij
approved these changes
Aug 11, 2021
|
Thank you for updating this! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://eslint.org/docs/rules/#deprecated where the following rules apply to the PDF.js project:
no-buffer-constructor, which we can replace with theunicorn/no-new-bufferrule; see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-new-buffer.mdno-catch-shadow, which was replaced by theno-shadowrule (that we're already using).