-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reduce the size of TextLayerRenderTask._textDivProperties
in "regular" text-selection mode
#13976
Reduce the size of TextLayerRenderTask._textDivProperties
in "regular" text-selection mode
#13976
Conversation
…ar" text-selection mode While these changes will obviously not have a significant effect on overall memory usage, it cannot hurt as far as I'm concerned. This patch makes the following changes: - Clear out `_textDivProperties` once rendering is done, since those properties are only necessary to keep alive when *enhanced* text-selection is being used. - Reduce the size of the `_textDivProperties`-entries by default, since a majority of the properties are only relevant when *enhanced* text-selection is being used.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3177f87ec3a4377/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3177f87ec3a4377/output.txt Total script time: 4.15 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9f5f2c691201623/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1ca0f8741942f90/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9f5f2c691201623/output.txt Total script time: 21.51 mins
Image differences available at: http://54.241.84.105:8877/9f5f2c691201623/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1ca0f8741942f90/output.txt Total script time: 39.66 mins
Image differences available at: http://54.193.163.58:8877/1ca0f8741942f90/reftest-analyzer.html#web=eq.log |
Thanks! |
While these changes will obviously not have a significant effect on overall memory usage, it cannot hurt as far as I'm concerned. This patch makes the following changes:
Clear out
_textDivProperties
once rendering is done, since those properties are only necessary to keep alive when enhanced text-selection is being used.Reduce the size of the
_textDivProperties
-entries by default, since a majority of the properties are only relevant when enhanced text-selection is being used.