Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Font renderer - get int8 instead of uint8 in composite glyphes (bug 1749563) #14456

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Font renderer - get int8 instead of uint8 in composite glyphes (bug 1749563) #14456

merged 1 commit into from
Jan 19, 2022

Conversation

calixteman
Copy link
Contributor

  • it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1749563;
  • use some helper functions to get (u|i)int** values in buffer: it helps to have a clearer code;
  • in composite glyphes the translations values with a transformations are signed so consequently get some int8 instead of uint8;
  • add few TODOs.

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f479e4f0a809a11/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/df5043040a98c90/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/df5043040a98c90/output.txt

Total script time: 22.78 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8

Image differences available at: http://54.241.84.105:8877/df5043040a98c90/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f479e4f0a809a11/output.txt

Total script time: 29.06 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c6fd0df024891e9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c6fd0df024891e9/output.txt

Total script time: 4.55 mins

Published

@Snuffleupagus Snuffleupagus linked an issue Jan 16, 2022 that may be closed by this pull request
Superscript Dot misplaced if Font Face disabled #8754
Closed
Snuffleupagus
Snuffleupagus approved these changes Jan 16, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed; thank you!

@Snuffleupagus Snuffleupagus mentioned this pull request Jan 16, 2022
Open
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6e65772c846ccfe/output.txt

Snuffleupagus
Snuffleupagus reviewed Jan 18, 2022
View reviewed changes
@calixteman
Font renderer - get int8 instead of uint8 in composite glyphes (bug 1…
74f25d2 
…749563)

 - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1749563;
 - use some helper functions to get (u|i)int** values in buffer: it helps to have a clearer code;
 - in composite glyphes the translations values with a transformations are signed so consequently get some int8 instead of uint8;
 - add few TODOs.
@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6e65772c846ccfe/output.txt

Total script time: 22.78 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/6e65772c846ccfe/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

I restarted the process on the win bot.
/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/63b45fb839c0902/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/63b45fb839c0902/output.txt

Total script time: 41.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 6
  different first/second rendering: 2

Image differences available at: http://54.193.163.58:8877/63b45fb839c0902/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit b0231cc into mozilla:master Jan 19, 2022
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/417fa232e7e5659/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8c44bd2ceb84a29/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/417fa232e7e5659/output.txt

Total script time: 20.60 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/8c44bd2ceb84a29/output.txt

Total script time: 38.15 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the 1749563 branch January 19, 2022 10:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
font-conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Superscript Dot misplaced if Font Face disabled
3 participants
@calixteman @pdfjsbot @Snuffleupagus