Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[UI] Avoid to have buttons in hover state after having been clicked (bug 836732) #14516

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

calixteman
Copy link
Contributor

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to update

.findbar input:focus + label {
as well, in order for all "buttons" on the generic Findbar to work correctly?

Also, looking at https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible#browser_compatibility this does seem to be a somewhat recent CSS feature. My initial thought would be that we do not attempt to polyfill this for now, in order to simplify things, unless we get lots of bug reports about this.

@calixteman
Copy link
Contributor Author

calixteman commented Jan 30, 2022

Don't you need to update

.findbar input:focus + label {

as well, in order for all "buttons" on the generic Findbar to work correctly?

Yep I missed there were some "buttons" here, thank you.

Also, looking at https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible#browser_compatibility this does seem to be a somewhat recent CSS feature. My initial thought would be that we do not attempt to polyfill this for now, in order to simplify things, unless we get lots of bug reports about this.

+1

…bug 836732)

 - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=836732;
 - replace :focus by :focus-visible for the buttons in the UI, according to the docs:
   - https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible
   - the button has the focus-visible state when it has been focused with the keyboard
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e070bddc429f9a4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/e070bddc429f9a4/output.txt

Total script time: 4.86 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and a lot simpler than I thought it'd be to fix that old bug (thanks to this "new" CSS feature); thank you!

@Snuffleupagus Snuffleupagus merged commit bff7eb8 into mozilla:master Jan 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants