-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[UI] Avoid to have buttons in hover state after having been clicked (bug 836732) #14516
Conversation
calixteman
commented
Jan 30, 2022
- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=836732;
- replace :focus by :focus-visible for the buttons in the UI, according to the docs:
- https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible
- the button has the focus-visible state when it has been focused with the keyboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to update
Line 562 in 7a03470
.findbar input:focus + label { |
Also, looking at https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible#browser_compatibility this does seem to be a somewhat recent CSS feature. My initial thought would be that we do not attempt to polyfill this for now, in order to simplify things, unless we get lots of bug reports about this.
Yep I missed there were some "buttons" here, thank you.
+1 |
…bug 836732) - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=836732; - replace :focus by :focus-visible for the buttons in the UI, according to the docs: - https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible - the button has the focus-visible state when it has been focused with the keyboard
b9a12e1
to
7dda856
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e070bddc429f9a4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e070bddc429f9a4/output.txt Total script time: 4.86 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and a lot simpler than I thought it'd be to fix that old bug (thanks to this "new" CSS feature); thank you!