Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable the browser-tests, during gulp makeref, in Google Chrome on the Windows bot (PR 14392 follow-up) #14517

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Disable the browser-tests, during gulp makeref, in Google Chrome on the Windows bot (PR 14392 follow-up) #14517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,11 +607,18 @@ function makeRef(done, bot) {
console.log();
console.log("### Creating reference images");

let forceNoChrome = false;
const args = ["test.js", "--masterMode"];
if (bot) {
const os = process.env.OS;
if (/windows/i.test(os)) {
// The browser-tests are too slow in Google Chrome on the Windows
// bot, causing a timeout, hence disabling them for now.
forceNoChrome = true;
}
args.push("--noPrompts", "--strictVerify");
}
if (process.argv.includes("--noChrome")) {
if (process.argv.includes("--noChrome") || forceNoChrome) {
args.push("--noChrome");
}

Expand Down