Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[GENERIC viewer] Remove the moz-prefixed FullScreen API usage from the viewer #14532

Merged

Conversation

@Snuffleupagus
Copy link
Collaborator Author

Looking at the compatibility data, it seems that nowadays only Safari needs the webkit-prefixed methods.
Based on the number of (general) issues we see related to the Safari-browser in particular, I can't help wonder if we maybe want to consider removing support for PresentationMode in browsers that lack the unprefixed FullScreen API or if that's (still) too soon?

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Feb 4, 2022

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/230429b99fac4d0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 4, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/230429b99fac4d0/output.txt

Total script time: 4.48 mins

Published

@timvandermeij timvandermeij merged commit 97619ba into mozilla:master Feb 5, 2022
@timvandermeij
Copy link
Contributor

Thank you for cleaning this up! Since this one is indeed obsolete but the Webkit one isn't yet, let's keep that one around for the time being.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants