[editor] Update the AnnotationStorage.hash-getter to support editing
#14993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While calling `JSON.stringify(...)` on a class-instance obviously "works" (as in it doesn't throw), since it's really just an Object, it doesn't really make much sense in the context of the `AnnotationStorage.hash`-getter. Also, access the *inverse* Viewport-transform correctly in `FreeTextEditor.serialize` to prevent errors being thrown when that method is invoked. Finally, slightly updates the `AnnotationStorage.serializable`-getter to improve consistency within the class.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6422d6d71795dd9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9e1abcc1a53a6a5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6422d6d71795dd9/output.txt Total script time: 4.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9e1abcc1a53a6a5/output.txt Total script time: 7.26 mins
|
calixteman
approved these changes
Jun 5, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While calling
JSON.stringify(...)on a class-instance obviously "works" (as in it doesn't throw), since it's really just an Object, it doesn't really make much sense in the context of theAnnotationStorage.hash-getter.Also, access the inverse Viewport-transform correctly in
FreeTextEditor.serializeto prevent errors being thrown when that method is invoked.Finally, slightly updates the
AnnotationStorage.serializable-getter to improve consistency within the class.