Don't hide the different layers when zooming #19186
Conversation
When hiding a layer we set de display to none and from time to time time, if the layer is focused, it causes a focus loss. It's especially annoying when the user is zooming while in the middle of a drawing session on mobile (it's pretty common to zoom in/out on such devices). In considering, that few years ago, a scaling was causing a complete re-rendering of a page, it made sense to just hide the layer during the scaling in order to avoid a mismatch between element dimensions in different layers. But nowadays, things are different because only the canvas is re-rendered the other layers are just scaled. So this patch shouldn't hurt.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/92790fbc735c96e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a9b3936e2f56286/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/92790fbc735c96e/output.txt Total script time: 10.28 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a9b3936e2f56286/output.txt Total script time: 23.53 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3181c7b4725b710/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3181c7b4725b710/output.txt Total script time: 0.99 mins Published |
|
A couple of questions, about code just "outside" of this patch:
|
| if (xfaLayerNode) { | ||
| // Hide the XFA layer until all elements are resized | ||
| // so they are not displayed on the already resized page. | ||
| this.xfaLayer.hide(); | ||
| } |
There was a problem hiding this comment.
Given that the xfaLayer is a bit special, is keeping it visible actually correct and safe in general?
Ninja-edit: Testing the preview the answer unfortunately seems to be NO, since scrolling to the end of an XFA document and then rotating it triggers intermittent rendering glitches (since pages that are not visible will not be updated until they are scrolled into view again).
Here's a screen-shot of what this looks like:
| if (annotationLayerNode) { | ||
| // Hide the annotation layer until all elements are resized | ||
| // so they are not displayed on the already resized page. | ||
| this.annotationLayer.hide(); | ||
| } | ||
| if (annotationEditorLayerNode) { | ||
| this.annotationEditorLayer.hide(); | ||
| } |
There was a problem hiding this comment.
What about pages that are still active in the PDFPageViewBuffer buffer, but not currently visible?
These annotation-related layers won't have e.g. their rotation updated until they become visible again, and it's not clear to me if that could cause them to overflow their respective page-containers (similar to the xfaLayer) and thus potentially "mess" with layout?
When hiding a layer we set de display to none and from time to time time, if the layer is focused, it causes a focus loss.
It's especially annoying when the user is zooming while in the middle of a drawing session on mobile (it's pretty common to zoom in/out on such devices).
In considering, that few years ago, a scaling was causing a complete re-rendering of a page, it made sense to just hide the layer during the scaling in order to avoid a mismatch between element dimensions in different layers.
But nowadays, things are different because only the canvas is re-rendered the other layers are just scaled. So this patch shouldn't hurt.