[api-major] Replace MissingPDFException and UnexpectedResponseException with one exception
#19264
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ad9497973319ffc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0cce005a60c938d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0cce005a60c938d/output.txt Total script time: 28.98 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ad9497973319ffc/output.txt Total script time: 54.33 mins
|
|
Given that this is part of the public API, and I can imagine that third-party implementations actually handle the current exceptions, should we perhaps classify this as |
Snuffleupagus
force-pushed
the
ResponseException
branch
from
9551077 to
9a5ed18
Compare
Snuffleupagus
changed the title
MissingPDFException and UnexpectedResponseException with one exceptionMissingPDFException and UnexpectedResponseException with one exception
I suppose that's a fair comment; I've updated the commit message and PR title. It's been a while since we bumped the major version number, and there's also a few things in progress (e.g. canvas tiling) that are significant enough to perhaps warrant a major version bump. |
Snuffleupagus
force-pushed
the
ResponseException
branch
2 times, most recently
from
3905adb to
b7c4ea9
Compare
…ption` with one exception These old exceptions have a fair amount of overlap given how/where they are being used, which is likely because they were introduced at different points in time, hence we can shorten and simplify the code by replacing them with a more general `ResponseException` instead. Besides an error message, the new `ResponseException` instances also include: - A numeric `status` field containing the server response status, similar to the old `UnexpectedResponseException`. - A boolean `missing` field, to allow easily detecting the situations where `MissingPDFException` was previously thrown.
Snuffleupagus
force-pushed
the
ResponseException
branch
from
b7c4ea9 to
eda9788
Compare
These old exceptions have a fair amount of overlap given how/where they are being used, which is likely because they were introduced at different points in time, hence we can shorten and simplify the code by replacing them with a more general
ResponseExceptioninstead.Besides an error message, the new
ResponseExceptioninstances also include:A numeric
statusfield containing the server response status, similar to the oldUnexpectedResponseException.A boolean
missingfield, to allow easily detecting the situations whereMissingPDFExceptionwas previously thrown.