Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

locally hosted viewer should allow any file location #9444

Closed
wants to merge 1 commit into from

Conversation

AlexejStukov
Copy link

Included 'qrc://' for Qt resource files

Included 'qrc://' for Qt resource files
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Feb 6, 2018

Please refer to PR #6916 for background on HOSTED_VIEWER_ORIGINS, and the related URL validation.

The default set of HOSTED_VIEWER_ORIGINS are the bare minimum that is necessary for https://mozilla.github.io/pdf.js/web/viewer.html to work. For any sort of custom implementation of the default viewer, you should edit HOSTED_VIEWER_ORIGINS as required yourself depending on the situation.

Hence I don't think that this is a change that we need/should make in the PDF.js library itself, which is why I'm closing the PR.

@AlexejStukov
Copy link
Author

Sorry did not see that. The comment // Hosted or local viewer, allow for any file locations had me thinking the current behaviour was unintentional.

@AlexejStukov AlexejStukov deleted the patch-1 branch February 6, 2018 09:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants