Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Billboard components margins are too large #138

Closed
alexgibson opened this issue Jun 5, 2018 · 0 comments
Closed

Billboard components margins are too large #138

alexgibson opened this issue Jun 5, 2018 · 0 comments
Assignees
@alexgibson
Labels
Bug 🪲 Something isn't working

Comments

@alexgibson
Copy link
Member

alexgibson commented Jun 5, 2018 •
edited
Loading

Billboard components have 160px margins, which is too large especially on small screens. This is not easily visible on the demo page, since it shows one billboard after anotyher and the negative image margin hides things. But when used in / around other content it becomes an issue.
@alexgibson alexgibson added the Bug 🪲 Something isn't working label Jun 5, 2018
@alexgibson alexgibson self-assigned this Jun 5, 2018
@alexgibson alexgibson mentioned this issue Jun 5, 2018
Merged
@alexgibson alexgibson changed the title Billboard components have too much bottom margin on small screens. Billboard components margins are too large Jun 6, 2018
craigcook pushed a commit that referenced this issue Jun 6, 2018
@alexgibson @craigcook
Adjust default margins for billboard components (Fixes #138) (#140)
cff8a63
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alexgibson alexgibson

Labels
Bug 🪲 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexgibson