-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Section with three columns #154
Comments
We might be able to leverage the card component styling. The cards currently use Zilla-Slab for the headlines but if the page has a Firefox theme class applied to it then the headlines should change to Open-Sans. Something along these lines:
|
Whilst re-using existing components is definitely a good thing and something we should always consider, there are a few differences here that Card components don't currently cover:
Whilst I'm not saying that leveraging existing Card styles is something we should avoid, we do still need to consider how complex a component with a single responsibility should get. The more variations we add to it, the more complicated it becomes. |
What I think I've settled on here is to make this a new variation of a card component as @michaelmccombie suggested. Because it shares little in common with a regular card however, it's likely not going to inherit all the base styles from a regular card, and instead use a base class of its own (e.g. For layout, we can still use |
Variations
Desktop (1024px)
Mobile (480px)
The text was updated successfully, but these errors were encountered: