Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Split components can overflow in very narrow viewports #843

Closed
craigcook opened this issue Jan 12, 2023 · 0 comments
Closed

Split components can overflow in very narrow viewports #843

craigcook opened this issue Jan 12, 2023 · 0 comments
Assignees
Labels
Bug 🪲 Something isn't working

Comments

@craigcook
Copy link
Member

craigcook commented Jan 12, 2023

Description

The element .mzp-c-split-container has the rule min-width: $content-xs; (304px) plus padding and margins, so in viewports narrower than 350px or so the Split stops shrinking and can overflow the viewport.

image

We could remove the min-width but need to see what the repercussions of that are. If removing it breaks things maybe we should at least reduce it to accommodate a 320px viewport (the original iPhone width).

@craigcook craigcook added the Bug 🪲 Something isn't working label Jan 12, 2023
@nathan-barrett nathan-barrett self-assigned this May 3, 2023
nathan-barrett added a commit that referenced this issue May 10, 2023
## Description
Removed the min-width on `.mzp-c-split-container` to prevent overflow on
very small viewports - I tried to see if it broke anything but it seemed
ok on my testing

- [x] I have recorded this change in `CHANGELOG.md`.

### Issue

#843 

### Testing
- `npm run webpack`
- `npm run start`
- http://localhost:3000/components/detail/split
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants