Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support ES2015 Promise #160

Closed
gbrail opened this issue Mar 10, 2015 · 9 comments · Fixed by #942
Closed

Support ES2015 Promise #160

gbrail opened this issue Mar 10, 2015 · 9 comments · Fixed by #942
Labels
feature Issues considered a new feature

Comments

@gbrail
Copy link
Collaborator

gbrail commented Mar 10, 2015

V8 has support for the ES6 "Promise" object.

@novabyte
Copy link

+1 would love to see this happen. 😃

@botic
Copy link

botic commented May 25, 2021

Just discovered the greg-promises branch and looks like there is a chance to see this in the future. Would be really a big help, even if async / await truly unleash the full power of Promises.

@p-bakker
Copy link
Collaborator

p-bakker commented Jun 1, 2021

@gbrail are you planning to merge the remaining of this branch somewhere in the future? I see a lot of the changes in this branch have already made it into master, which the major exception of the actual Promises implementation

@gbrail
Copy link
Collaborator Author

gbrail commented Jun 1, 2021 via email

@p-bakker
Copy link
Collaborator

p-bakker commented Jun 1, 2021

So pretty close, great! Have you given async/await any thought?

@p-bakker
Copy link
Collaborator

Has any thought been given to debugging Promises?

As these introduce the async programming model more prominently in Rhino, I wonder what support there'll be for debugging async 'callstacks'.

Platforms like Chrome/V8/Node support async debugging and async stacktraces for example

@p-bakker p-bakker modified the milestones: ES2015, Release 1.7.14 Jun 28, 2021
@p-bakker p-bakker changed the title Support Promise Support ES2015 Promise Jun 29, 2021
@p-bakker p-bakker pinned this issue Jul 1, 2021
@p-bakker p-bakker unpinned this issue Jul 2, 2021
@p-bakker p-bakker added the feature Issues considered a new feature label Oct 13, 2021
@p-bakker
Copy link
Collaborator

@gbrail am wondering if we need followup cases for the following things:

  1. debug support for promises & async stacktraces (see Support ES2015 Promise #160 (comment))
  2. Java Interoperability for Promises (see Implement promises #942 (comment) and Implement promises #942 (comment))

@gbrail
Copy link
Collaborator Author

gbrail commented Nov 29, 2021

Yes, I think that if we have comments in PRs from things that we already merged and closed that we should turn them into issues. Thanks for looking at all this!

@p-bakker
Copy link
Collaborator

p-bakker commented Nov 29, 2021

Was more checking to hear whether they are still things to be tackled.

Will create the cases!

See #1109 & #1108

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature Issues considered a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants