-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reflect and Proxy implementation #1660
Conversation
Once again, how do we move forward on this? I don't want to let it just sit. I think that we have two options:
|
8ca0db7
to
a490650
Compare
I do not like the idea of a feature flag because it is sooo demotivating.
In the past we let things in
And also some old stuff like
I have the feeling doing all this discussion about the this PR is not really fair compared to the stuff we already have. This is just the personal point of view, but i guess that most of the work is done based on a strong motivation by the peoples that doing this work. And together with all the technical things we have to have the motivation of the people in mind to go forward here (like we did in the last months). But i will try to handle this serious - i will try to spend some time to document the problems in separate issues (but my time is really limited for the next months) and also i will rebase this like i did in the last weeks. |
a490650
to
4a1e572
Compare
Current stats
|
4a1e572
to
ad27703
Compare
So far, this has come down to a conflict between contributors, as to whether or not we merge this. I think that this PR adds an important set of new capability to Rhino and that we should have it. Unless someone has a strong objection, I'm asking @rbri to do one more conflict resolution, and then we should take it. And after that, I'm going to propose that we call it a day and ship Rhino 1.8.0! |
@gbrail will do the rebase after all the fantastic stuff from @andreabergia and friends is merged |
ad27703
to
7a58552
Compare
7a58552
to
90e77b8
Compare
@gbrail rebase is done |
Thanks for all your work on this! |
this is an recreation of #1637 from scratch
Closes #268