Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert Map and Set to use lambdas #1800

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Conversation

gbrail
Copy link
Collaborator

@gbrail gbrail commented Jan 13, 2025

  • Convert NativeMap to lambda
  • Partial work on lambdas for native map and set.
  • Use aliases for properties that need to be the same

@rbri
Copy link
Collaborator

rbri commented Jan 15, 2025

@gbrail had a quick look at this - looks good and another minor step forward.

Just saw that some WeakMap/Set tests are still failing - i guess our code does not accept symbols as weak map keys.

https://tc39.es/ecma262/multipage/executable-code-and-execution-contexts.html#sec-canbeheldweakly

Maybe you can fix that on the way...

@gbrail
Copy link
Collaborator Author

gbrail commented Jan 23, 2025

Thanks for the feedback -- I'm a bit behind on this because I ran in to some serialization difficulties with another lambda-related PR and I want to understand all that. I wish that serialization would just go away (and TBH a few years ago I believe the Java community was advocating for that) but it didn't and I believe that continuations use it so I'm going to keep on trying to figure it out.

@aardvark179
Copy link
Contributor

Getting rid of the current serialisation code will be a long road, even though it is one of the most painful things a whole load of JDK stuff.

I like the way this lambda stuff in general as I think it aligns nicely with long term ideas I have round slot maps and properties.

@gbrail gbrail force-pushed the greg-more-lambdas branch from af94299 to 9c4f6ad Compare January 29, 2025 03:28
@rbri
Copy link
Collaborator

rbri commented Jan 29, 2025

Super cool, another step forward

@gbrail gbrail marked this pull request as ready for review January 30, 2025 05:39
@gbrail gbrail merged commit 0d1ca69 into mozilla:master Jan 31, 2025
3 checks passed
@gbrail gbrail deleted the greg-more-lambdas branch January 31, 2025 06:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants