Skip to content

new release of lru-disk-cache with updated dependicies on crates.io ? #813

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Dushistov opened this issue Jul 21, 2020 · 4 comments
Closed

new release of lru-disk-cache with updated dependicies on crates.io ? #813

Dushistov opened this issue Jul 21, 2020 · 4 comments
Milestone
0.2.14

Comments

@Dushistov
Copy link
Contributor

No description provided.

@Bobo1239
Copy link

Bobo1239 commented Oct 4, 2020

Note that Rust 1.48 will break the current lru-disk-cache release since linked-hash-map 0.2 doesn't contain contain-rs/linked-hash-map#100 which causes a panic (since there's UB) since rust-lang/rust#71274. (e.g. panicked at 'attempted to leave type `linked_hash_map::Node<std::ffi::OsString, u64>` uninitialized, which is invalid')

@fasterthanlime
Copy link

which causes a panic (since there's UB)

We're also seeing this, releasing a new version of lru-disk-cache sounds good (or having the older linked-hash-map version yanked, see contain-rs/linked-hash-map#100 (comment))

facebook-github-bot pushed a commit to facebookincubator/below that referenced this issue Nov 21, 2020
@jkeljo @facebook-github-bot
Work around lru-disk-cache UB in Rust 1.48
547b9b3 
Summary: `lru-disk-cache` depends on an old version of `linked-hash-map` which contains UB in 1.48 (see mozilla/sccache#813). They updated the deps in their repo months ago, but haven't pushed a new version. This diff makes us get `lru-disk-cache` directly from their GitHub instead.

Reviewed By: dtolnay

Differential Revision: D25134582

fbshipit-source-id: 05fd63a76b7095ebeea458645b92a83bbd8c4614
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this issue Nov 21, 2020
@jkeljo @facebook-github-bot
Work around lru-disk-cache UB in Rust 1.48
8f2f4d9 
Summary: `lru-disk-cache` depends on an old version of `linked-hash-map` which contains UB in 1.48 (see mozilla/sccache#813). They updated the deps in their repo months ago, but haven't pushed a new version. This diff makes us get `lru-disk-cache` directly from their GitHub instead.

Reviewed By: dtolnay

Differential Revision: D25134582

fbshipit-source-id: 05fd63a76b7095ebeea458645b92a83bbd8c4614
facebook-github-bot pushed a commit to facebook/sapling that referenced this issue Nov 21, 2020
@jkeljo @facebook-github-bot
Work around lru-disk-cache UB in Rust 1.48
8cb2b9b 
Summary: `lru-disk-cache` depends on an old version of `linked-hash-map` which contains UB in 1.48 (see mozilla/sccache#813). They updated the deps in their repo months ago, but haven't pushed a new version. This diff makes us get `lru-disk-cache` directly from their GitHub instead.

Reviewed By: dtolnay

Differential Revision: D25134582

fbshipit-source-id: 05fd63a76b7095ebeea458645b92a83bbd8c4614
@ash2x3zb9cy ash2x3zb9cy mentioned this issue Nov 30, 2020
Closed
@glandium glandium added this to the 0.2.14 milestone Dec 11, 2020
@glandium
Copy link
Collaborator

lru-disk-cache 0.4.1 now published: https://crates.io/crates/lru-disk-cache/0.4.1

@fasterthanlime
Copy link

Thanks so much @glandium !

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.14
Development

No branches or pull requests
4 participants
@Dushistov @glandium @Bobo1239 @fasterthanlime