don't preventDefault on links

mozilla · Aug 3, 2017 · 1d688bf · 1d688bf
1 parent 09cc047
commit 1d688bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 19 deletions.
diff --git a/frontend/src/download.js b/frontend/src/download.js
@@ -15,23 +15,17 @@ $(document).ready(function() {
   $('.send-new').attr('href', window.location.origin);
 
   $('.send-new').click(function(target) {
-    target.preventDefault();
     sendEvent('recipient', 'restarted', {
       cd2: 'completed'
-    }).then(() => {
-      location.href = target.currentTarget.href;
-    });
+    })
   });
 
   $('.legal-links a, .social-links a, #dl-firefox').click(function(target) {
-    target.preventDefault();
     const metric = findMetric(target.currentTarget.href);
     // record exited event by recipient
     sendEvent('recipient', 'exited', {
       cd3: metric
-    }).then(() => {
-      location.href = target.currentTarget.href;
-    });
+    })
   });
 
   const filename = $('#dl-filename').text();

diff --git a/frontend/src/upload.js b/frontend/src/upload.js
@@ -23,35 +23,25 @@ $(document).ready(function() {
   $('#file-upload').change(onUpload);
 
   $('.legal-links a, .social-links a, #dl-firefox').click(function(target) {
-    target.preventDefault();
     const metric = findMetric(target.currentTarget.href);
     // record exited event by recipient
     sendEvent('sender', 'exited', {
       cd3: metric
-    }).then(() => {
-      location.href = target.currentTarget.href;
     });
   });
 
   $('#send-new-completed').click(function(target) {
-    target.preventDefault();
     // record restarted event
     sendEvent('sender', 'restarted', {
       cd2: 'completed'
-    }).then(() => {
-      storage.referrer = 'completed-upload';
-      location.href = target.currentTarget.href;
     });
   });
 
   $('#send-new-error').click(function(target) {
-    target.preventDefault();
     // record restarted event
+    storage.referrer = 'errored-upload';
     sendEvent('sender', 'restarted', {
       cd2: 'errored'
-    }).then(() => {
-      storage.referrer = 'errored-upload';
-      location.href = target.currentTarget.href;
     });
   });