abort uploads over maxfilesize #266
Conversation
|
R+ on the string |
| max_file_size: { | ||
| format: Number, | ||
| default: (1024 * 1024 * 1024) * 2, | ||
| env: 'P2P_MAX_FILE_SIZE' |
There was a problem hiding this comment.
I thought we were removing all "P2P" references - rename?
There was a problem hiding this comment.
yeeeaaaah, i wanted to rename them all at once, but not in this PR, so... 🤷♂️
There was a problem hiding this comment.
but it's a new variable, is it not? unless you have an .env file that I am unaware of?
| }, | ||
| max_file_size: { | ||
| format: Number, | ||
| default: (1024 * 1024 * 1024) * 2, |
There was a problem hiding this comment.
Add a comment about what real-world value this is? I assume its 2GB.
There was a problem hiding this comment.
comments always tend to diverge from reality. do the math 💪
There was a problem hiding this comment.
Fair enough. But to be clear, the UI says the recommended file limit is 1GB for uploads, but the server will allow up to ~2GB max?
There was a problem hiding this comment.
both hard limits are the same. the recommendation is just a suggestion
frontend/src/download.js
Outdated
| `${filename} (${(progress[0] / 1000000).toFixed(1)}MB of ${(progress[1] / 1000000000).toFixed(1)}GB)` | ||
| ); | ||
| } | ||
| $('.progress-text').text(`${filename} (${bytes(progress[0])} of ${bytes(progress[1])})`); |
There was a problem hiding this comment.
I think this may be causing some UI jank as well. You can see in the following UI screenshot that the filesizes are rounded to 2 decimal places. I think in some cases during upload, it's rounding the ".00" to ".0" which causes the UI to slightly shift very briefly.
This may all be academic though since I believe @johngruen also has a PR to tweak the UI, so not sure who's PR will "win".
Fixes #180
bytesmodule cuz im lazy