Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Add ESLint no-alert shame rule #369

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

pdehaan
Copy link
Contributor

@pdehaan pdehaan commented Aug 1, 2017

alert() is a bit gross. So adding ESLint rule that warns on usage so we can eventually be shamed into a better UI solution (since alert() and prompt() and confirm() can eventually be dismissed by the user with a "stop doing this" option -- which would be some bad UX).

$ git grep "alert" frontend/src

frontend/src/upload.js:          alert(str);
frontend/src/upload.js:        .then(alert);

Copy link
Contributor

@dannycoates dannycoates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. i don't look at warnings anyway 😜

@dannycoates dannycoates merged commit ada4532 into mozilla:master Aug 2, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants