This repository has been archived by the owner on May 22, 2021. It is now read-only.
Adjust hover behavior on send-logo (#382) #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericawright
suggested changes
Aug 2, 2017
There was a problem hiding this comment.
This is great, thank you!
One small nit:
In order to match the .site-subtitle a:hover rule, can you put the transition rule on .send-logo h1, and then the color rule on the hover state.
That way the transition applies to the hover happening, and the hover going away.
Fixes: #382
|
Should I amend the previous commit, or two separate commits is OK? |
|
@weihanglo whichever you prefer is fine |
ericawright
approved these changes
Aug 2, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adjusted highlight targets to
h1anda. Now it looks like this:Not quite sure if this fits the original design.