This repository has been archived by the owner on May 22, 2021. It is now read-only.
improved popup for mobile display; Fixes #699 #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dannycoates could you review please ? |
dannycoates
suggested changes
Jan 11, 2018
assets/main.css
Outdated
| border-bottom: 1px solid #d7d7db; | ||
| border-left: 1px solid #fff; | ||
| border-top: 1px solid #fff; | ||
| } |
There was a problem hiding this comment.
It shouldn't be necessary to redefine all these css attributes here. We should only set the ones that need to be overridden or added.
There was a problem hiding this comment.
Yeah that's true, I'll make the required changes
assets/main.css
Outdated
| border-top: 1px solid #fff; | ||
| } | ||
|
|
||
| #deletePopup { |
There was a problem hiding this comment.
Is this supposed to be only in this media block?
There was a problem hiding this comment.
Well, Yes. Changing its left properties help us to shift it (popup) to the center. However, I'll remove the extra statements
shikhar-scs
force-pushed
the
delete-popup-mobile-view
branch
from
9545aa4 to
8711009
Compare
|
@dannycoates I've removed the extra statements, and squashed the commits. Please review. |
dannycoates
approved these changes
Jan 12, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @SoftVision-CiprianMuresan at #699, the popup for mobile view has been centered and thus now falls in the visible window. Here's a preview
Please review