Skip to content

Commit

Permalink
chore(ci): Removed nodejs 12 from CI jobs (#2387)
Browse files Browse the repository at this point in the history
* chore(ci): Removed nodejs 12 from CI jobs

* chore(ci): Workaround 'digital envelope routines::unsupported' error triggered by webpack on nodejs 17
  • Loading branch information
rpl authored Mar 28, 2022
1 parent c368750 commit 666886f
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,9 @@ references:
# The nodejs version set as `nodejs_current` is the one used to
# release the package on npm.
nodejs_versions:
- &nodejs_current "12.22"
- &nodejs_next "14.19"
- &nodejs_experimental "16.14"
## NOTE: the nodejs version shipped with circleci/windows@2.4.0 orb
## (v12.11.1) fails on the test-functional test related to importing
## web-ext as a library (see https://github.com/mozilla/web-ext/pull/2221),
## the issue seems to have been fixed on more recent nodejs versions
## (any version >= 12.16.0).
- &nodejs_current_win "12.22.1"
- &nodejs_current "14.19"
- &nodejs_next "16.14"
- &nodejs_experimental "17.7"

nodejs_enum: &nodejs_enum
type: enum
Expand Down Expand Up @@ -166,12 +160,17 @@ commands:

jobs:
build:
<<: *defaults
parameters:
node_options:
type: string
default: ""
nodejs:
<<: *nodejs_enum
<<: *defaults
docker:
- image: cimg/node:<< parameters.nodejs >>
environment:
NODE_OPTIONS: << parameters.node_options >>
steps:
- attach_project_repo
- checkout
Expand Down Expand Up @@ -222,9 +221,9 @@ jobs:
parameters:
nodejs:
type: enum
default: *nodejs_current_win
default: *nodejs_current
enum:
- *nodejs_current_win
- *nodejs_current
<<: *defaults
executor:
name: win/default
Expand Down Expand Up @@ -290,6 +289,9 @@ workflows:
- build:
name: build-nodejs-experimental
nodejs: *nodejs_experimental
## workaround `npm run build` issue triggered by webpack
## on nodejs 17.
node_options: --openssl-legacy-provider
filters:
tags:
only: /.*/
Expand Down

0 comments on commit 666886f

Please # to comment.