Support GHC 9.10 #149
Draft
Support GHC 9.10 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhrcek Thanks for the PR! I'm on PTO at the moment, will try to get back to this as soon as I can. In the meantime, if you are motivated to fix more tests, feel free to do so! |
|
2b11376 fixed a few test failures. This also fixes a few, such as However it causes many new test failures. I'm going to look into this tomorrow. |
|
The fact that this doesn't work with GHC 9.10 means HLint no longer gets replacements with GHC 9.10, which is a little bit of a shame. But I can document it if that is the expected outcome. |
|
@ndmitchell Yes unfortunately ghc-exactprint doesn't quite work with GHC 9.10. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @zliu41
I see you created ghc-9.10 branch but the last commit on it is from a month ago.
I'd like to help moving this forward, because I'd like to get hlint plugin enabled in haskell language server for ghc 9.10. But that is blocked by hlint upgrade to ghc 9.10, which in turn is blocked by upgrading apply-refact to ghc 9.10 😄
Working off your branch, I managed to reduce the amount of test failures from 249 to 79 doing two small changes.
Do you intend to get back to this?
If not, I can try my best over the weekend to move this forward..