Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do a proper mpl version check #297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zhitao-Li
Copy link

Current version check will fail when mpl version becomes equal or greater than 3.10.

@ianhi
Copy link
Collaborator

ianhi commented Feb 22, 2025

Hi @Zhitao-Li thank you very much for the PR! This is definitely a bug, however I'd prefer to fix it by comparing to the new (since matplotlib version 3.5) __version_info__ provided by matplotlib like in this commit:

mpl-extensions/mpl-image-segmenter@1203e8f

Are you able to modify your PR to that? Then I'll happily accept and merge

@ianhi
Copy link
Collaborator

ianhi commented Feb 22, 2025

Ah actually: @Zhitao-Li please consider switching to using the standalone package for the image segmenter: mpl-image-segmenter. I plan on deprecating and removing it from this package and only supporting the standalone package going forward.

In addition to having bugfixes it also has some new features not in this version. See discussion here: https://mpl-image-segmenter.readthedocs.io/en/latest/differences.html

@Zhitao-Li
Copy link
Author

Thanks for the suggestion, I am switching to the new package. However, it looks like there is a similar bug in that package as well.

@ianhi
Copy link
Collaborator

ianhi commented Feb 24, 2025

What version are you using there? It should be fixed in version 0.2.1

@Zhitao-Li
Copy link
Author

Yeah, sorry about the confusion, the pip package was out of date, now I am using a development install from the git repository, it is fixed.

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants