Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wrong Serdang location #28

Closed
iqfareez opened this issue Nov 25, 2020 · 5 comments
Closed

Wrong Serdang location #28

iqfareez opened this issue Nov 25, 2020 · 5 comments
Assignees
@iqfareez
Labels
bug Something isn't working critical Need quic fix!

Comments

@iqfareez
Copy link
Member

This bug may affect people around Serdang, Selangor.

The issue caused from https://mpt.i906.my/ API.

We might issue a temporary fix for this.
image

Any PR is welcomed.
@iqfareez iqfareez added bug Something isn't working critical Need quic fix! labels Nov 25, 2020
@iqfareez iqfareez self-assigned this Nov 25, 2020
@iqfareez iqfareez pinned this issue Nov 25, 2020
@iqfareez
Copy link
Member Author

iqfareez commented Jan 29, 2021 •
edited
Loading

Proposed Solution:

by Aizal Manan from email

  1. Go to https://api.azanpro.com/zones and copy their listing into your DB
  2. Get device location
  3. Using radius, get nearest zone from listing in Step 1
  4. Pass that zone code to https://www.e-solat.gov.my/index.php?r=esolatApi/takwimsolat&period=week&zone=SGR01

That's mean, we need to kinda rebuild the backend. We are also slowly ditching current 3rd party API (mpti906),

@iqfareez
Copy link
Member Author

Screenshot 2021-01-30 081420

Alhamdulillah, I was be able to perform above pseudocode, it works well. So far, it matches with jakim code database in every location is tested.

@iqfareez
Copy link
Member Author

Check passed. Will implement it soon

iqfareez added a commit that referenced this issue Feb 7, 2021
@iqfareez
👽 Ditch location mpti906. #28
0ae0548
@iqfareez
Copy link
Member Author

iqfareez commented Feb 9, 2021

Beta release out now 👀

iqfareez added a commit that referenced this issue Feb 11, 2021
@iqfareez
Ditch mpt location api (#47)
a0420b2 
* Added Location Coordinate

* Added geolocoding
Added two files from test_gps_flutter
change cupertino import to material
done replace some mpti906api

* 👽 Ditch location mpti906. #28

* 🔥 mpti906 location model etc deleted

* Hoooray! Successfully get prayer time JAKIM api

* Sucess get location to new API

* deprecated mpti906 method

* Done reabling notification

* 🚀 Release test 1.12.79-beta+37
iqfareez added a commit that referenced this issue Feb 16, 2021
@iqfareez
🚀 Release 1.13.87+41 #45 #28
bc6d3fc
@iqfareez
Copy link
Member Author

Fixed in latest release. Closing.

@iqfareez iqfareez unpinned this issue Feb 19, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@iqfareez iqfareez

Labels
bug Something isn't working critical Need quic fix!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iqfareez